D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-29 Thread Méven Car
meven abandoned this revision. meven added a comment. See D25010 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. It's actually an approach to be preferred in such cases, as it moves some of the work to be done at creating KF6 and porting to its new API for users of KF to now and the time span until KF6, keeping the unavoidable hurdle at the actual KF5->KF6 change as small as

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Méven Car
meven added a comment. In D24999#555191 , @kossebau wrote: > Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be the preferred variant. REPOSITORY R241 KIO REVISION DETAIL

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. you may want to explain a bit more what you mean there. it could make sense to keep the TODO in the .cpp file, no need to get it on every user REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: apol,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Méven Car
meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24999 AFFECTED

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Méven Car
meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns