D25059: KPluginSelector: use new KAboutPluginDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog (authored by kossebau). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25059?vs=69004=70260 REVISION

D25059: KPluginSelector: use new KAboutPluginDialog

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH useaboutplugindialog REVISION DETAIL https://phabricator.kde.org/D25059 To: kossebau, #frameworks, dfaure, apol Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,

D25059: KPluginSelector: use new KAboutPluginDialog

kossebau added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kpluginselector.cpp:799-803 > Can you guard for nullptr? The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks. We should be relatively safe here, as the slot should be

D25059: KPluginSelector: use new KAboutPluginDialog

anthonyfieroni added inline comments. INLINE COMMENTS > kpluginselector.cpp:799-803 > +PluginEntry *pluginEntry = model->data(index, > PluginEntryRole).value(); > +KPluginMetaData pluginMetaData = pluginEntry->pluginInfo.toMetaData(); > + > +KAboutPluginDialog

D25059: KPluginSelector: use new KAboutPluginDialog

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Depends on D25058