D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven abandoned this revision. meven added a comment. In favor of D28555 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > file_unix.cpp:266 > #ifdef USE_SENDFILE > -bool use_sendfile = buff_src.st_size < 0x7FFF; > +bool use_sendfile = true; > #endif This prevented using sendfile for file bigger than 2 GB. Our code

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > file_unix.cpp:58 > +// Defaults to 5MB so the user can follow copy progress > +#define SENDFILE_CHUNK_SIZE (5 * 1024 * 1024) > #endif I have reduced the value to 5 MB so that users can still follow progress,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven updated this revision to Diff 69075. meven added a comment. Limit sendfile chunk size to 5MB so that users can still follow progress while enjoying faster copy REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69065=69075 BRANCH master

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven added a comment. In D25079#556824 , @ahmadsamir wrote: > Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276 The bug scope is rather large. But this will help and I suspect https://phabricator.kde.org/D23523 will too.

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

ahmadsamir added a comment. Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

sitter added a comment. TBH, I would move away from the hardcoding in general try to sendfile size_of_file and `if n < size` use n as new count for the next cycle. The second cycle will use the maximum regardless of what the specific kernel version has as maximum. The maximum is an

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven updated this revision to Diff 69065. meven added a comment. Update quote from man sendfile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69064=69065 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25079 AFFECTED FILES

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

apol added a comment. This is really interesting, I can expect this to make the whole thing much faster. INLINE COMMENTS > file_unix.cpp:55 > +// On Linux, write() (and similar system calls) will transfer at most > +// 0x7000 (2,147,479,552) bytes, returning the number of bytes > +//

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven updated this revision to Diff 69064. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69063=69064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25079 AFFECTED FILES

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven created this revision. meven added reviewers: dfaure, Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY We had a bad value of 32,768 bytes to copy at once. But Linux