D25159: Fix linking to libssh 0.9.1

sitter added a comment. D25170 for when that lands REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter, fvogt Cc: nisavid, fvogt, sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel,

D25159: Fix linking to libssh 0.9.1

asn added a comment. I've created https://gitlab.com/libssh/libssh-mirror/merge_requests/71 This means the right code would be then. if (TARGET ssh) # libssh 0.9+ target_link_libraries(kio_sftp ssh) endif() REPOSITORY R320 KIO Extras REVISION DETAIL

D25159: Fix linking to libssh 0.9.1

arojas abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter, fvogt Cc: fvogt, sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D25159: Fix linking to libssh 0.9.1

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. The libssh maintainer is likely reverting the change, so this should not be necessary. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To:

D25159: Fix linking to libssh 0.9.1

asn added a comment. The plan is to have ssh as the target name and nothing else and support BUILD_SHARED_LIBS. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter Cc: sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel,

D25159: Fix linking to libssh 0.9.1

sitter added a comment. In D25159#559016 , @asn wrote: > We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different. > > I'm currently trying to fix it. However better

D25159: Fix linking to libssh 0.9.1

asn added a comment. We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different. I'm currently trying to fix it. However better don't apply this as ssh_shared will vanish as a target. I wonder how I can define

D25159: Fix linking to libssh 0.9.1

sitter added subscribers: asn, sitter. sitter accepted this revision. sitter added a comment. I think there's a smarter way of dealing with this somewhere in our finder, not blocking though. I'll take a look when I find a minute. @asn it seems to me the cmake config broke compat between

D25159: Fix linking to libssh 0.9.1

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Fixes the build for me too, patch looks good. Thanks! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol Cc: apol, asturmlechner,

D25159: Fix linking to libssh 0.9.1

arojas retitled this revision from "Fix linking to libssh 0.9" to "Fix linking to libssh 0.9.1". arojas edited the summary of this revision. arojas edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas Cc: