This revision was automatically updated to reflect the committed changes.
Closed by commit R237:23d4f14601fd: Only create a session config when actually
restoring a session (authored by ngraham).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
session-config (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25219
To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni,
ngraham updated this revision to Diff 70054.
ngraham marked an inline comment as done.
ngraham added a comment.
Check for `sessionConfig()` being nullptr
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25219?vs=69464=70054
BRANCH
session-config (branched
anthonyfieroni added inline comments.
INLINE COMMENTS
> kconfiggui.cpp:73
> {
> return sessionConfig()->name();
> }
sessionConfig() can be nullptr can you add a check.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25219
To: ngraham, #frameworks,
ngraham added a comment.
Can I get a review on this?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25219
To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham added a comment.
Ping.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25219
To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham added a dependent revision: D11382: Add an option to show tabs from
last time when Dolphin starts.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25219
To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham retitled this revision from "Also only create a session config when
actually restoring a session" to "Only create a session config when actually
restoring a session".
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25219
To: ngraham, #frameworks,
