cullmann added a comment.
Ok, ah, no longer applies cleanly, must redo some things it seems.
Will create a new patch for submission.
REVISION DETAIL
https://phabricator.kde.org/D2545
To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks
dfaure added a comment.
I don't mind, go ahead.
REVISION DETAIL
https://phabricator.kde.org/D2545
To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks
cullmann added a comment.
David, could we apply this patch, even with the workaround in the Qt patch in
craft to have a better experience for people not patching their Qt?
REVISION DETAIL
https://phabricator.kde.org/D2545
To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka,
cullmann added a comment.
Given we always needs to patch Qt for this, shall we not use this workaround
in our code instead?
I think the other "it always hangs" stuff in Qt bug
https://bugreports.qt.io/browse/QTBUG-49870 got fixed.
Would this patch here making patching Qt not needed for
kfunk abandoned this revision.
kfunk added a comment.
Patched Qt instead:
https://phabricator.kde.org/R138:7f78f7297add7c510c1cf0f1707197c8c403fcee
I can't make my mind up how to fix this cleanly, to be honest.
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
kfunk added a comment.
In https://phabricator.kde.org/D2545#69298, @thiago wrote:
> In https://phabricator.kde.org/D2545#69187, @kfunk wrote:
>
> > In https://phabricator.kde.org/D2545#69091, @thiago wrote:
> >
> > > There doesn't seem to be a way of doing some clean up before the
thiago added a comment.
In https://phabricator.kde.org/D2545#69187, @kfunk wrote:
> In https://phabricator.kde.org/D2545#69091, @thiago wrote:
>
> > There doesn't seem to be a way of doing some clean up before the threads
are forcibly killed.
> >
> > Maybe if I abuse qtmain().
kfunk added a comment.
In https://phabricator.kde.org/D2545#69091, @thiago wrote:
> There doesn't seem to be a way of doing some clean up before the threads
are forcibly killed.
>
> Maybe if I abuse qtmain().
This would only fix it for non-console GUI applications if I
kfunk added a comment.
For the record, since I don't see an easy fix I'm pondering about patching
qtbase in craft.git:
Ideas:
a ) Add this to QDBusConnectionManager ctor:
qAddPostRoutine([]() {
QMetaObject::invokeMethod(QDBusConnectionManager::instance(), "quit");
kfunk added a comment.
> Here's the other problem: it's possible for threads to simply disappear on
Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I
can't rule out that this has happened. Qt 5.6 has a workaround to another
deadlock caused by Windows. Can you try
thiago added a comment.
In https://phabricator.kde.org/D2545#66904, @thiago wrote:
> Commit ad66dbe305cff72443f4d3484191872d56e6dfbb in qtbase did try to solve
this by disconnecting the senders when the objects were getting deleted.
closeConnection() is called before the thread exits
thiago added a comment.
In https://phabricator.kde.org/D2545#66545, @kfunk wrote:
> In https://phabricator.kde.org/D2545#65976, @dfaure wrote:
>
> > Actually, I think Thiago's still waiting for a backtrace of all threads.
>
>
> I think I've already said this via other channels:
kfunk added a comment.
In https://phabricator.kde.org/D2545#65976, @dfaure wrote:
> Actually, I think Thiago's still waiting for a backtrace of all threads.
I think I've already said this via other channels: There's only one thread
left at this point.
BRANCH
master
REVISION
albertvaka added a comment.
Since there is no fix on Qt, should we merge this?
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, vonreth, dfaure
Cc: albertvaka, mutlaqja,
mutlaqja added a comment.
Any update on this?
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, vonreth, dfaure
Cc: mutlaqja, arrowdodger, #frameworks
dfaure added a comment.
We need a backtrace with all threads to understand what's happening.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, vonreth, dfaure
Cc: arrowdodger,
kfunk added a comment.
Here's the backtrace (note: using Qt 5.6 branch):
ntdll.dll!NtWaitForSingleObject () Unknown
KernelBase.dll!7ffbcb2eaadf() Unknown
> Qt5Core.dll!QWaitCondition::wait(QMutex * mutex=0x01c24fd16520,
unsigned long
dfaure added a comment.
So what is the actual deadlock you're experiencing?
I showed this to Thiago and he said he needs more info on what is actually
happening, i.e. where exactly it deadlocks in QtDBus.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL
arrowdodger added a comment.
In https://phabricator.kde.org/D2545#48488, @dfaure wrote:
> Hmm can you check if https://codereview.qt-project.org/161056 fixes it?
I've tried both Thiago patches on 5.7 branch and they don't fix this problem.
BRANCH
master
REVISION DETAIL
dfaure added a comment.
Hmm can you check if https://codereview.qt-project.org/161056 fixes it?
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, vonreth, dfaure
Cc: #frameworks
kfunk added a comment.
Bump?
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, dfaure, vonreth
Cc: #frameworks
kfunk updated this revision to Diff 6175.
kfunk added a comment.
Fix typo in commit msg
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2545?vs=6173=6175
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2545
AFFECTED FILES
src/kuiserverjobtracker.cpp
kfunk added reviewers: dfaure, vonreth.
kfunk added a subscriber: Frameworks.
REVISION DETAIL
https://phabricator.kde.org/D2545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, dfaure, vonreth
Cc: #frameworks
23 matches
Mail list logo
