This revision was automatically updated to reflect the committed changes.
Closed by commit R242:57fdb5679081: support for user removing background and
automatic shadow (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
mart/effectiveBackgroundHints
REVISION DETAIL
https://phabricator.kde.org/D25590
To: mart, #plasma, davidedmundson
Cc: davidedmundson, ndavis,
mart marked an inline comment as done.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D25590
To: mart, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
mart updated this revision to Diff 70544.
mart added a comment.
- better effectiveBackgroundHints comparizon
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25590?vs=70513=70544
BRANCH
mart/effectiveBackgroundHints
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> ndavis wrote in configuration-icons.svg:17
> I couldn't see any issues in the SVG code. @mart Where is `showbackground`
> used in the UI so that I can test it?
in the patch, it adds a new icon in the handle, tough you need this plus D25591
ndavis added inline comments.
INLINE COMMENTS
> davidedmundson wrote in configuration-icons.svg:17
> @ndavis can you review this icon change please
I couldn't see any issues in the SVG code. @mart Where is `showbackground` used
in the UI so that I can test it?
REPOSITORY
R242 Plasma
davidedmundson added a comment.
That ended up quite nice in the end ++
INLINE COMMENTS
> appletinterface.cpp:414
> emit backgroundHintsChanged();
> +if (!m_userBackgroundHintsInitialized || !(m_backgroundHints &
> Plasma::Types::ConfigurableBackground)) {
> +emit
mart updated this revision to Diff 70513.
mart added a comment.
- ImmutableBackground->configurableBackground
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25590?vs=70503=70513
BRANCH
mart/effectiveBackgroundHints
REVISION DETAIL
mart updated this revision to Diff 70503.
mart marked 3 inline comments as done.
mart added a comment.
- adress comments
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25590?vs=70496=70503
BRANCH
mart/effectiveBackgroundHints
davidedmundson added subscribers: ndavis, davidedmundson.
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> colorscope.cpp:52
>
> -QQuickItem *parentItem = qobject_cast(parentObject);
>
mart edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D25590
To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mart added inline comments.
INLINE COMMENTS
> plasma.h:285
> +ImmutableBackground = 8, /** The user shouldn't have the possibility
> to */
> DefaultBackground = StandardBackground /**< Default settings: both
> standard background */
> };
DefaultBackground should be
mart added a dependent revision: D25592: handle action for custom shadow
background hint.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D25590
To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mart added a dependent revision: D25591: support for the shadow and
effectiveBackgroundhints.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D25590
To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.
REVISION SUMMARY
add the ability for the user to override the background hints anddecide
about applets having
15 matches
Mail list logo