D25590: support for user removing background and automatic shadow

2019-11-29 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:57fdb5679081: support for user removing background and automatic shadow (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25590: support for user removing background and automatic shadow

2019-11-29 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH mart/effectiveBackgroundHints REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma, davidedmundson Cc: davidedmundson, ndavis,

D25590: support for user removing background and automatic shadow

2019-11-29 Thread Marco Martin
mart marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma, davidedmundson Cc: davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

2019-11-29 Thread Marco Martin
mart updated this revision to Diff 70544. mart added a comment. - better effectiveBackgroundHints comparizon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25590?vs=70513=70544 BRANCH mart/effectiveBackgroundHints REVISION DETAIL

D25590: support for user removing background and automatic shadow

2019-11-29 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > ndavis wrote in configuration-icons.svg:17 > I couldn't see any issues in the SVG code. @mart Where is `showbackground` > used in the UI so that I can test it? in the patch, it adds a new icon in the handle, tough you need this plus D25591

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > davidedmundson wrote in configuration-icons.svg:17 > @ndavis can you review this icon change please I couldn't see any issues in the SVG code. @mart Where is `showbackground` used in the UI so that I can test it? REPOSITORY R242 Plasma

D25590: support for user removing background and automatic shadow

2019-11-28 Thread David Edmundson
davidedmundson added a comment. That ended up quite nice in the end ++ INLINE COMMENTS > appletinterface.cpp:414 > emit backgroundHintsChanged(); > +if (!m_userBackgroundHintsInitialized || !(m_backgroundHints & > Plasma::Types::ConfigurableBackground)) { > +emit

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart updated this revision to Diff 70513. mart added a comment. - ImmutableBackground->configurableBackground REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25590?vs=70503=70513 BRANCH mart/effectiveBackgroundHints REVISION DETAIL

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart updated this revision to Diff 70503. mart marked 3 inline comments as done. mart added a comment. - adress comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25590?vs=70496=70503 BRANCH mart/effectiveBackgroundHints

D25590: support for user removing background and automatic shadow

2019-11-28 Thread David Edmundson
davidedmundson added subscribers: ndavis, davidedmundson. davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > colorscope.cpp:52 > > -QQuickItem *parentItem = qobject_cast(parentObject); >

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > plasma.h:285 > +ImmutableBackground = 8, /** The user shouldn't have the possibility > to */ > DefaultBackground = StandardBackground /**< Default settings: both > standard background */ > }; DefaultBackground should be

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart added a dependent revision: D25592: handle action for custom shadow background hint. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart added a dependent revision: D25591: support for the shadow and effectiveBackgroundhints. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

2019-11-28 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add the ability for the user to override the background hints anddecide about applets having