D25673: Deprecate KServiceTypeProfile

2020-01-02 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R309:486af98fe900: Deprecate KServiceTypeProfile (authored by nicolasfella). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25673?vs=72590=72612 REVISION DETAIL

D25673: Deprecate KServiceTypeProfile

2020-01-02 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R309 KService BRANCH arcpatch-D25673 REVISION DETAIL https://phabricator.kde.org/D25673 To: nicolasfella, #frameworks, dfaure Cc: dfaure, apol,

D25673: Deprecate KServiceTypeProfile

2020-01-01 Thread Nicolas Fella
nicolasfella updated this revision to Diff 72590. nicolasfella added a comment. - Update update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25673?vs=72589=72590 BRANCH arcpatch-D25673 REVISION DETAIL https://phabricator.kde.org/D25673 AFFECTED

D25673: Deprecate KServiceTypeProfile

2020-01-01 Thread Nicolas Fella
nicolasfella updated this revision to Diff 72589. nicolasfella added a comment. - Update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25673?vs=70708=72589 BRANCH arcpatch-D25673 REVISION DETAIL https://phabricator.kde.org/D25673 AFFECTED FILES

D25673: Deprecate KServiceTypeProfile

2020-01-01 Thread Nicolas Fella
nicolasfella marked an inline comment as done. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25673 To: nicolasfella, #frameworks Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25673: Deprecate KServiceTypeProfile

2019-12-18 Thread David Faure
dfaure added a comment. Indeed missing "@deprecated since 5.66" --- and now the macros need s/65/66/ everywhere. As I'm the kservice maintainer (listed in the yaml file), please add me to kservice merge requests so I can react faster. REPOSITORY R309 KService REVISION DETAIL

D25673: Deprecate KServiceTypeProfile

2019-12-01 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kservicetypeprofile.h:50 > * @param disabledServices List of services which are normally associated > with this serviceType, > * but which should be disabled, i.e. trader queries will not return them. > */ @deprecated 5.65 REPOSITORY R309

D25673: Deprecate KServiceTypeProfile

2019-12-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's unused. See T12287