This revision was automatically updated to reflect the committed changes.
Closed by commit R284:9fe2d187f8e9: [KHistoryComboBox] Add method to set an
icon provider (authored by nicolasfella).
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R284 KCompletion
BRANCH
icopro
REVISION DETAIL
https://phabricator.kde.org/D25700
To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 71098.
nicolasfella marked 3 inline comments as done.
nicolasfella added a comment.
- Comments
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25700?vs=71072=71098
BRANCH
icopro
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> khistorycombobox.cpp:415
>
> +#if KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66)
> void KHistoryComboBox::setPixmapProvider(KPixmapProvider *provider)
nicolasfella added a reviewer: dfaure.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D25700
To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 71072.
nicolasfella added a comment.
- For real
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25700?vs=71071=71072
BRANCH
icopro
REVISION DETAIL
https://phabricator.kde.org/D25700
AFFECTED FILES
nicolasfella updated this revision to Diff 71071.
nicolasfella added a comment.
- Adapt deprecation version
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25700?vs=71070=71071
BRANCH
icopro
REVISION DETAIL
https://phabricator.kde.org/D25700
nicolasfella updated this revision to Diff 71070.
nicolasfella added a comment.
- Deprecation, fix, and docs
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25700?vs=70794=71070
BRANCH
icopro
REVISION DETAIL
https://phabricator.kde.org/D25700
apol added a comment.
+1 Makes sense to me
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D25700
To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 70794.
nicolasfella added a comment.
- Deprecation, fix, and docs
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25700?vs=70791=70794
BRANCH
icopro
REVISION DETAIL
https://phabricator.kde.org/D25700
nicolasfella edited the summary of this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D25700
To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella added a task: T12310: Kill KUrlPixmapProvider.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D25700
To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
An icon provider can be any function that takes a QString and
13 matches
Mail list logo