D25743: Expose IndexerState enum to QML

justinzobel added a comment. Can we please continue this over on Gitlab? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: justinzobel, bruns, broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots

D25743: Expose IndexerState enum to QML

bruns added a comment. In D25743#619435 , @davidedmundson wrote: > > Ping. > > Will do on Sunday (after tagging) Which Sunday? ;-) REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: da

D25743: Expose IndexerState enum to QML

davidedmundson added a comment. > Ping. Will do on Sunday (after tagging) REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast0

D25743: Expose IndexerState enum to QML

ngraham added a comment. Ping. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposh

D25743: Expose IndexerState enum to QML

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n

D25743: Expose IndexerState enum to QML

broulik added inline comments. INLINE COMMENTS > baloomonitorplugin.cpp:31 > qmlRegisterType(uri, 0, 1, "Monitor"); > +qmlRegisterUncreatableMetaObject(Baloo::staticMetaObject, uri, 0, 1, > "Baloo", "Error: only enums"); > } I have to also add a qRegisterMetaType(); in order to be

D25743: Expose IndexerState enum to QML

ngraham added a subscriber: broulik. ngraham added a comment. @broulik discovered that this needs `qRegisterMetaType();` added REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan

D25743: Expose IndexerState enum to QML

ngraham added a comment. Thanks! `Baloo::Suspended` doesn't seem to be exported properly or set. Also it seems like `toggleSuspendState()` only ever suspends and never resumes. Looking at the code in `monitor.cpp`, it seems like these may be related. REPOSITORY R293 Baloo REVISION DE

D25743: Expose IndexerState enum to QML

davidedmundson updated this revision to Diff 73757. davidedmundson added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25743?vs=70985&id=73757 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 AFFECTED FILES src/file

D25743: Expose IndexerState enum to QML

ngraham added a comment. Now this patch no longer applies cleanly after those changes; needs a rebase. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampal

D25743: Expose IndexerState enum to QML

davidedmundson added a comment. > Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while balooctl status disagrees. There were several other problems wi

D25743: Expose IndexerState enum to QML

ngraham added a comment. @davidedmundson ping. This needs to make it into Frameworks 5.66 this is tagged in a week if the dependent patches are to land in Plasma 5.18. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-

D25743: Expose IndexerState enum to QML

ngraham added a comment. Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while ` balooctl status` disagrees. REPOSITORY R293 Baloo REVISION DETAIL http

D25743: Expose IndexerState enum to QML

davidedmundson updated this revision to Diff 70985. davidedmundson edited the summary of this revision. davidedmundson added a comment. redo without the export REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25743?vs=70906&id=70985 BRANCH master REVISION D

D25743: Expose IndexerState enum to QML

davidedmundson planned changes to this revision. davidedmundson added a comment. Q_NAMESPACE_EXPORT is too new :( REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00

D25743: Expose IndexerState enum to QML

ngraham added a comment. This doesn't compile for me: [ 11%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/indexerstate.cpp.o In file included from /home/nate/kde/src/baloo/src/engine/indexerstate.cpp:1: /home/nate/kde/src/baloo/src/engine/indexerstate.h:32:19: e

D25743: Expose IndexerState enum to QML

ngraham added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns,

D25743: Expose IndexerState enum to QML

ngraham added a dependent revision: D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampal

D25743: Expose IndexerState enum to QML

davidedmundson created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This no longer is just private API of the file code as we're using this all over balooctl an