D25822: Add manual test for changing colorscope in components

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a3acfbfce605: Add manual test for changing colorscope in components (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D25822: Add manual test for changing colorscope in components

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Thanks again :) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: ngraham, kde-frameworks-de

D25822: Add manual test for changing colorscope in components

davidedmundson updated this revision to Diff 71139. davidedmundson added a comment. Thanks Updated all the things. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25822?vs=71123&id=71139 BRANCH master REVISION DETAIL https://pha

D25822: Add manual test for changing colorscope in components

filipf added a comment. In D25822#574271 , @ngraham wrote: > Nice. Does this fix or obsolete D25699 ? No, this just for easier testing of all the components with the complementary theme. REPOSITORY R

D25822: Add manual test for changing colorscope in components

filipf added a comment. Thanks! It will be easier to test now. I noticed some issues with certain tests, although most seem to have already existed: - busyindicator3.qml -> loads, but complains about a binding loop detected for `implicitHeight` - button3.qml -> doesn't load, says

D25822: Add manual test for changing colorscope in components

ngraham added a comment. Nice. Does this fix or obsolete D25699 ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bru

D25822: Add manual test for changing colorscope in components

davidedmundson added a reviewer: filipf. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25822: Add manual test for changing colorscope in components

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY For quickly other bugs in PC3 TEST PLAN Opened qmlscene on some files It's only for unit tests anyway