D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R174:ce6699a141a0: Align ECM and Qt setup with Frameworks conventions (authored by vkrause). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71575=71576

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause updated this revision to Diff 71575. vkrause added a comment. Remove duplicate include. REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71573=71575 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26011 AFFECTED FILES

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:28 > include(ECMSetupVersion) > include(FeatureSummary) > include(ECMQtDeclareLoggingCategory) Remove this one REPOSITORY R174 KContacts

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This completes the previous commit which provided the hotfix for the ECM version lookup issue breaking the build.