D26171: Implement wp_viewporter

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH viewporter REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26171: Implement wp_viewporter

romangg updated this revision to Diff 72576. romangg added a comment. - Cleanup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26171?vs=72575=72576 BRANCH viewporter REVISION DETAIL https://phabricator.kde.org/D26171 AFFECTED FILES

D26171: Implement wp_viewporter

romangg updated this revision to Diff 72575. romangg marked 6 inline comments as done. romangg added a comment. - Check source rectangle on related changes, buffer rename. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26171?vs=72029=72575 BRANCH

D26171: Implement wp_viewporter

davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in surface_interface.cpp:882 > How I read the spec: the source rectangle is always specified in coordinates > after scale and transform. [1] > > `SurfaceInterface::size()` returns the scaled and transformed (not yet) >

D26171: Implement wp_viewporter

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:485 > We're not testing this error in the case of: > > buffer is set > viewporter.sourceRect is set > > then later > buffer changes > viewporter.sourceRect remains the same > > this should be an

D26171: Implement wp_viewporter

davidedmundson added a comment. Cool, I like viewporter. INLINE COMMENTS > surface_interface.cpp:464 > + > +sizeChanged |= (bool)buffer; > +} C-style casts are frowned upon. > surface_interface.cpp:485 > +if (!QRectF(QPointF(), >

D26171: Implement wp_viewporter

romangg added a task: T4456: Implement viewporter protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

romangg added inline comments. INLINE COMMENTS > surface_interface.h:130 > + **/ > +BufferInterface *constBuffer() const; > QPoint offset() const; Needed for a call in a const function in KWin. Do we want to do it like that? Other suggestions? REPOSITORY R127 KWayland REVISION

D26171: Implement wp_viewporter

romangg added a dependent revision: D26172: Add wp_viewporter support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This patch adds interfaces for specifying viewports via the wp_viewporter protocol