D26191: Add support for FileJob->truncate() in smb/sftp slaves

This revision was automatically updated to reflect the committed changes. Closed by commit R320:3bb841890e5a: Add support for FileJob-truncate() in smb/sftp slaves (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=73308=73309

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 73308. feverfew added a comment. - Merge branch 'master' into arcpatch-D26191 - adhere to protcol -> json switch REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=73306=73308 BRANCH arcpatch-D26191

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 73306. feverfew added a comment. Cleanup code according to comments REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72584=73306 BRANCH arcpatch-D26191 REVISION DETAIL

D26191: Add support for FileJob->truncate() in smb/sftp slaves

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio,

D26191: Add support for FileJob->truncate() in smb/sftp slaves

sitter accepted this revision. sitter added a comment. I do wonder if maybe more granular return value handling of the smb truncate would be in order, but then I suppose the most relevant error is EACCES and that'd be handled at opening ¯\_(ツ)_/¯ LGTM INLINE COMMENTS > dfaure wrote in

D26191: Add support for FileJob->truncate() in smb/sftp slaves

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kio_sftp.cpp:1478 > +void sftpProtocol::truncate(KIO::filesize_t length) { > +qCDebug(KIO_SFTP_LOG) << "truncate, length = " << length; > + [minor: qDebug already appends spaces between arguments, so you get two

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72584. feverfew added a comment. Fix introduction of BIC method REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72181=72584 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72181. feverfew added a comment. Add fact that protocol supports truncation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72155=72181 BRANCH arcpatch-D26191 REVISION DETAIL

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew marked 3 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72155. feverfew added a comment. Avoid code duplication REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72154=72155 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 AFFECTED

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72154. feverfew added a comment. Avoid free(NULL) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72104=72154 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 AFFECTED FILES

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew added inline comments. INLINE COMMENTS > fvogt wrote in kio_sftp.cpp:1492 > AFAICT, this has to be done in every case. I wasn't too sure if `attr` was needed by libssh if the call succeeded. Looking at the source code it seems that you are probably right and can be freed in all

D26191: Add support for FileJob->truncate() in smb/sftp slaves

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1480 > +if (!attr) { > +sftp_attributes_free(attr); > +int errorCode = toKIOError(sftp_get_error(mSftp)); This entire block is

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew added a dependency: D26148: Add truncation support to FileJob. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, LeGast00n, MrPepe,

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72104. feverfew added a comment. - Free unneeded struct pointer REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72103=72104 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26191 AFFECTED

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew created this revision. feverfew added reviewers: sitter, dfaure, fvogt. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This implements the new method added in D26148