This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:816abe85ad6a: Display fully qualified class/namespace
name as page header (authored by davidre).
CHANGED PRIOR TO
ochurlaud added a comment.
One minor correction then you can ship it
INLINE COMMENTS
> generator.py:456
> +else:
> +mapping['classname'] = mapping['fullname'] = None
>
Prefer the use of 2 settings to None instead of this double one. It's more
explicit for
elvisangelaccio added a reviewer: ochurlaud.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D26197
To: davidre, ochurlaud
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n,
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna
ngraham added a comment.
Looks sensible to me too FWIW.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D26197
To: davidre
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n,
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna
aacid added a comment.
I've no idea about the code, but looks sensible to me, so take this as a +2
if noone reviews in a while i guess :)
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D26197
To: davidre
Cc: aacid, jucato, kde-frameworks-devel, kde-doc-english,
davidre edited the summary of this revision.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D26197
To: davidre
Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
davidre edited the test plan for this revision.
davidre added a subscriber: jucato.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D26197
To: davidre
Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,
fbampaloukas, GB_2, michaelh, ngraham, bruns,
davidre edited the test plan for this revision.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D26197
To: davidre
Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
davidre created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
davidre requested review of this revision.
REVISION SUMMARY
It's the most important information to see quickly what the page is about.
Using the
