This revision was automatically updated to reflect the committed changes.
Closed by commit R309:128ed7ce3a1e: Remove endl in qDebug as its already
add \n + port to Qt::endl in qt5.15 (authored by mlaurent).
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R309 KService
BRANCH
port_endl (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26303
To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
mlaurent added a comment.
Ping ?:)
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D26303
To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mlaurent added inline comments.
INLINE COMMENTS
> apol wrote in plugintest.cpp:60
> std::endl should just work with cout.
static QTextStream cout(stdout);
it's a QTextStream
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D26303
To: mlaurent, dfaure
Cc: apol,
apol added inline comments.
INLINE COMMENTS
> plugintest.cpp:60
>
> -cout << "-- KPluginTrader Test --" << endl;
> +cout << "-- KPluginTrader Test --"
> +#if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0))
std::endl should just work with cout.
REPOSITORY
R309 KService
REVISION
mlaurent added a reviewer: dfaure.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D26303
To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Port endl method for compiling against qt5.15
REPOSITORY
R309 KService
BRANCH
port_endl (branched from master)
