D26331: Removed reading description from .desktop files AND .directory files

ngraham added a comment. In D26331#588152 , @count wrote: > In D26331#588073 , @ngraham wrote: > > > Thanks! @count, can you provide us with your full name and email address so we can land this

D26331: Removed reading description from .desktop files AND .directory files

count added a comment. In D26331#588073 , @ngraham wrote: > Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information? It's count negative

D26331: Removed reading description from .desktop files AND .directory files

ngraham added a comment. Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure,

D26331: Removed reading description from .desktop files AND .directory files

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

ngraham accepted this revision. ngraham added a comment. Everybody good with this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

count updated this revision to Diff 72807. count added a comment. added removing of .directory files reading REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26331?vs=72803=72807 REVISION DETAIL https://phabricator.kde.org/D26331 AFFECTED FILES

D26331: Removed reading description from .desktop files AND .directory files

count set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

ngraham added a comment. I think you lost the original diff with the latest update to this patch. REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

count updated this revision to Diff 72803. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26331?vs=72490=72803 REVISION DETAIL https://phabricator.kde.org/D26331 AFFECTED FILES src/core/kfileitem.cpp To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham,

D26331: Removed reading description from .desktop files AND .directory files

count retitled this revision from "Removed reading description from desktop files" to "Removed reading description from .desktop files AND .directory files". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham

D26331: Removed reading description from desktop files

ngraham added a comment. Makes sense to me, following the same logic. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from desktop files

count added a comment. Ok, I've played a little around, and imho we should remove the support for .directory file comments too: Here you see, the type column is read from the comment field inside the .directory file F7861776: screen.png

D26331: Removed reading description from desktop files

broulik added a comment. > unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?) Works here. F7860716: Screenshot_20200104_204817.png I think it doesn't update the view live when the comment changes

D26331: Removed reading description from desktop files

bruns added a comment. In D26331#587259 , @dfaure wrote: > On the other hand I see that the dolphin GUI has an editable "Comment" on the right side, unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?).

D26331: Removed reading description from desktop files

dfaure added a comment. OK, remove it. The other feature (kfilemetadata?) should be fixed though REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26331: Removed reading description from desktop files

ngraham added a comment. Having been a sysadmin setting up computers for new users, let me tell you that there is a 0% chance that I would use this feature. I would (and did, and have) *by far* prefer to document anything slightly confusing using an internal company-wide knowledge-base or

D26331: Removed reading description from desktop files

dfaure added a comment. I don't understand this line of argumentation. Are you saying that all documentation in the world is useless? You're setting up a computer for a new employee, with a whole lot of folders. Having some room to document "inline" the purpose of some folders sounds

D26331: Removed reading description from desktop files

ngraham added a comment. In D26331#586842 , @broulik wrote: > I doubt naming a folder "Technobabble" and then adding a helpful comment "This is where your cat pictures go" is very useful to the inexperienced user 100% agree REPOSITORY

D26331: Removed reading description from desktop files

broulik added a comment. In D26331#586783 , @count wrote: > I thought, the !d->isSlow() would skip that part for (fsType == KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in kfileitem.cpp:763. So I would leave that here.

D26331: Removed reading description from desktop files

dfaure added a comment. Also, I see a lot more use cases for showing the comment from .directory files. I could imagine setting up a computer for an inexperienced user, and adding .directory files to document what some directories are about. REPOSITORY R241 KIO REVISION DETAIL

D26331: Removed reading description from desktop files

count added a comment. In D26331#586565 , @broulik wrote: > What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757

D26331: Removed reading description from desktop files

broulik added a comment. What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757 REPOSITORY R241 KIO REVISION DETAIL

D26331: Removed reading description from desktop files

ngraham accepted this revision. ngraham added a comment. Can you please provide your name and email address so we can land this patch with the correct authorship information? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks,

D26331: Removed reading description from desktop files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I looked into the git/svn history and this actually is from before my time (lol), and a remnant of the fact that in the initial design by Torben, desktop files were a kmimetype-subclass

D26331: Removed reading description from desktop files

ngraham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

ngraham added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

count edited the summary of this revision. count edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

ngraham added reviewers: Frameworks, Dolphin. ngraham added a comment. It would be helpful if you could update the description to mention why this change is being made and when benefit comes from not reading desktop files' comment fields. Also, updating the Test Plan section with

D26331: Removed reading description from desktop files

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

count added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

count created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. count requested review of this revision. REVISION SUMMARY For https://bugs.kde.org/show_bug.cgi?id=382325 i've removed reading comments inside desktop files. REPOSITORY R241 KIO