D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 73261. meven added a comment. remove a commo in comment, fix @since version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73260=73261 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D26407

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 73260. meven marked an inline comment as done. meven added a comment. And KMountPoint::List::findByPathDirectly to check mount point without resolving symlinks REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > > when a network mount is unresponsive > > If I do a `QFileInfo` on an unresponsive mount it will still block. You > already freeze before you even know it's a network mount. Good point, indeed the current

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > anthonyfieroni wrote in kfileitem.cpp:49-50 > Put them in `getMountPoints` as local static variables, global static are > no-go. I agree. > meven wrote in

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

broulik added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:783 > Good point I have edited the commit message > when a network mount is unresponsive If I do a `QFileInfo` on an unresponsive mount it will still block. You already freeze before you even know it's a network

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > Yes, but the "never blocks" claim in the commit message is misleading. Good point I have edited the commit message REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 72738. meven marked 3 inline comments as done. meven added a comment. amend commit title REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=72732=72738 BRANCH arcpatch-D26407 REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven retitled this revision from "KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs" to "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs". REPOSITORY R241 KIO