D26457: Introduce shadow API

zzag updated this revision to Diff 73352. zzag added a comment. - Make KWindowShadow a QObject subclass (for memory management) - Clarify that it is okay to call destroy() after window() had been removed - Check whether QWindow has QPlatformWindow associated with it REPOSITORY R278 KWind

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > zzag wrote in kwindowshadow.h:201 > Oh, that one... Yeah, perhaps it will be worth to handle surface > creation/destruction in kwayland-integration. Okay, looks like it's do-able. However, we would need to call `QWidget::winId()` in `Breeze::Shadow

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwindowshadow.h:201 > kwayland-integration > > 0a0c3f23fce265f36e5b8fb2b4b8bd311c7c1beb > > src/windowsystem/windoweffects.cpp Oh, that one... Yeah,

D26457: Introduce shadow API

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in kwindowshadow.h:201 > Could you please point me to that code? kwayland-integration 0a0c3f23fce265f36e5b8fb2b4b8bd311c7c1beb src/windowsystem/windowe

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwindowshadow.h:201 > For KWindowEffects I did put window tracking into the wayland plugin and it > improved the readability of all the client code considerably. > > I would recommend looking at doing so, especially as we cou

D26457: Introduce shadow API

davidedmundson added a comment. Seems generally very clean and sensible. +1 I want to see plasma-framework/dialog.cpp and breeze ports before we merge. INLINE COMMENTS > kwindowshadow.h:201 > + * > + * Note that the KWindowShadow does not keep track of the platform > surface. If

D26457: Introduce shadow API

zzag updated this revision to Diff 72880. zzag added a comment. Remove pointless default member initializers in KWindowShadowPrivate. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=72862&id=72880 BRANCH kwindowshadow REVISION DETAIL htt

D26457: Introduce shadow API

zzag added a task: T12496: Shadows API in KWindowSystem. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26457 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new API provides a platform-independent way for setting drop-shadows on a window. X11 and W