trmdi updated this revision to Diff 73337.
trmdi added a comment.
- Move the flag to DropJob header, rename
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73273=73337
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I agree with the approach. Just naming needs to be improved.
I'd call the method "showMenu" or "showPopup".
DelayPopup hints at a builtin timer, better call it something
trmdi marked 5 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
michaelh, bruns
trmdi retitled this revision from "Popup menu again to reposition it" to "Add
KIO::DelayPopup flag and DropJob::menuPopup()".
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson,
