D26634: Correctly compute bottom margin for grid delegates with subtitles

This revision was automatically updated to reflect the committed changes. Closed by commit R296:083b21c4073f: Correctly compute bottom margin for grid delegates with subtitles (authored by ngraham). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26634?vs=

D26634: Correctly compute bottom margin for grid delegates with subtitles

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH compute-bottom-margin-correctly (branched from master) REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik, davidedmundson Cc: gvg

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. No worries! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26634: Correctly compute bottom margin for grid delegates with subtitles

gvgeo added a comment. In D26634#593595 , @ngraham wrote: > That's what you see with this patch? My apologies, I've made an error. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. In D26634#593553 , @gvgeo wrote: > Then, is it an option to create GridDelegateSubtitles.qml instead? > As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space. > > now vs

D26634: Correctly compute bottom margin for grid delegates with subtitles

gvgeo added a comment. Then, is it an option to create GridDelegateSubtitles.qml instead? As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space. now vs before F7881612: slim empty.png In this example

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham updated this revision to Diff 73446. ngraham marked 2 inline comments as done. ngraham added a comment. Fix comment whitespace REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26634?vs=73445&id=73446 BRANCH compute-bottom-margin-correctly (bra

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > gvgeo wrote in GridDelegate.qml:81 > Maybe need to add caption.visible check, instead of always removing 3 > gridUnits? > Was changed from 2 in the previous commit. If I do that, then grids where some del

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham updated this revision to Diff 73445. ngraham added a comment. Work around https://bugreports.qt.io/browse/QTBUG-49646 REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26634?vs=73439&id=73445 BRANCH compute-bottom-margin-correctly (branched fro

D26634: Correctly compute bottom margin for grid delegates with subtitles

gvgeo added inline comments. INLINE COMMENTS > GridDelegate.qml:81 > height: Kirigami.Settings.isMobile ? Math.round((delegate.width - > Kirigami.Units.gridUnit) / 1.6) > : > Math.min(delegate.GridView.view.implicitCellHeight - Kirigami.Units

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. Oh wow, I just noticed that putting these labels in a ColumnLayout triggered the infamous QML text kerning bug! https://bugreports.qt.io/browse/QTBUG-49646 Could that be a clue to solving it maybe? Seeing this now, I can revert the change to use a ColumnLayou

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY When I added the subtitle feature, I didn't notice that the bottom margin