D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ngraham added a comment. Hmm, I'm not totally sure I agree. If the text becomes focusable by tabbing, then I think that just clutters up the focus chain with non-interactive UI elements that nobody is actually going to care about doing something with 99% of the time. REPOSITORY R236

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

dfaure added a comment. IMHO the proper fix is to make tabbing work, and to fix Qt not to show a caret when the label gets the focus via a mouse click. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

This revision was automatically updated to reflect the committed changes. Closed by commit R236:945f1849cc24: [KMessageBox] Only allow selecting text in the dialog box using the mouse (authored by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ngraham added a comment. In D26649#593825 , @broulik wrote: > So you can't tab around to end up focusing the text field? As Noah said, you already can't. This doesn't change anything about what you can focus with the tab key. REPOSITORY

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ndavis added a comment. In D26649#593825 , @broulik wrote: > So you can't tab around to end up focusing the text field? You currently aren't able to, but after you click with the mouse on the text, you can use the arrow keys to move an I

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

broulik added a comment. So you can't tab around to end up focusing the text field? REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, when you select text in the dialog box, an insertion point