D26840: Correctly set underMouse() for inline notes

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7f043fbb26d4: inline notes: correctly set underMouse() for inline notes (authored by brauch). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26840?vs=74110=74351#toc REPOSITORY R39

D26840: Correctly set underMouse() for inline notes

brauch added a comment. Ok, done ;) REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL https://phabricator.kde.org/D26840 To: davidre, #ktexteditor, cullmann, brauch Cc: brauch, cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2,

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#600618 , @brauch wrote: > If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution. Feel free to! REPOSITORY R39 KTextEditor BRANCH underMouse

D26840: Correctly set underMouse() for inline notes

brauch accepted this revision. brauch added a comment. If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution. REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL https://phabricator.kde.org/D26840

D26840: Correctly set underMouse() for inline notes

brauch added a comment. I'm sorry, updateView is the wrong function to call, you need updateDirty. I tried it out, like this it works: if (e->buttons() == Qt::NoButton) { auto noteData = inlineNoteAt(e->globalPos()); if (noteData.m_position.isValid()) { if

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#599974 , @brauch wrote: > Then it seems like the line is not tagged correctly. Maybe try `tagLines(note.position.line(), note.position.line())`? I think the column being the same is not what the function being

D26840: Correctly set underMouse() for inline notes

brauch added a comment. Then it seems like the line is not tagged correctly. Maybe try `tagLines(note.position.line(), note.position.line())`? I think the column being the same is not what the function being called expects. REPOSITORY R39 KTextEditor BRANCH underMouse (branched from

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#599152 , @brauch wrote: > My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is

D26840: Correctly set underMouse() for inline notes

brauch added a comment. My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is tagged dirty, it gets repainted correctly, but too late. REPOSITORY R39

D26840: Correctly set underMouse() for inline notes

brauch added a comment. Hm, yeah, looking at the code I think you might need to call `updateView()` in case a focus in or out happened. Can you try if that makes a difference? REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#599082 , @brauch wrote: > Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing. > > Is it possible that

D26840: Correctly set underMouse() for inline notes

brauch added a comment. Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing. Is it possible that the line (and thus the note) is not properly marked for repaint when the underMouse

D26840: Correctly set underMouse() for inline notes

davidre added a comment. I stumbled upon while doing https://invent.kde.org/kde/kdevelop/merge_requests/92 REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL https://phabricator.kde.org/D26840 To: davidre, #ktexteditor, cullmann Cc: cullmann,

D26840: Correctly set underMouse() for inline notes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable. Btw., does somebody use that now for something useful? REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL

D26840: Correctly set underMouse() for inline notes

davidre edited the test plan for this revision. davidre added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26840 To: davidre, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D26840: Correctly set underMouse() for inline notes

davidre created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davidre requested review of this revision. REVISION SUMMARY Before it was always false for every inline note. REPOSITORY R39 KTextEditor BRANCH underMouse