albertvaka added a comment.
@vonreth @broulik Can you folks give this a final review? We have been
building KDE Connect for Windows off a custom branch with this patch, but I
would like to use official builds of KNotifications so it would be great if we
can merge it.
REPOSITORY
R289
brute4s99 marked 2 inline comments as done.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26888
To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
brute4s99 updated this revision to Diff 80333.
brute4s99 added a comment.
work around to fully support the windows backend
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26888?vs=74291=80333
BRANCH
arcpatch-D26888
REVISION DETAIL
albertvaka added inline comments.
INLINE COMMENTS
> notifybysnore.cpp:135-139
> +if (id == -1) {
> +emit actionInvoked(0, actionNum);
> +} else {
> +emit actionInvoked(id, actionNum);
> +}
This could become:
if (id == -1) {
meven added inline comments.
INLINE COMMENTS
> notifybysnore.cpp:165
>
> -void NotifyBySnore::notifyDeferred(KNotification* notification)
> -{
> +Q_UNUSED(config);
> QProcess *proc = new QProcess();
no `;` here
REPOSITORY
R289 KNotifications
REVISION DETAIL
brute4s99 reclaimed this revision.
brute4s99 added a comment.
sorry. abandoned wrong diff
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26888
To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
brute4s99 added reviewers: vonreth, broulik, KDE Connect.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26888
To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
brute4s99 abandoned this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26888
To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
brute4s99 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.
REVISION SUMMARY
really support the windows backend.
REPOSITORY
R289 KNotifications
BRANCH
windows (branched from master)
