D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos updated this revision to Diff 75727. eudoxos added a comment. Fix indentation lines shown spuriously when horizontal space was unsufficient for indent fill REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75533&id=75727 BRANCH dynwrap-

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. Note to myself: should handle the case when width percentage disallows the indent, e.g. here: F8104336: image.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: mwolff,

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

mwolff added a comment. In D27285#611163 , @dhaumann wrote: > Ok, I now fully got this, thanks for the explanation. And indeed without any left fill visual feedback is missing. > > What I wonder is how much of this needs to be configurable. W

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

dhaumann added a subscriber: cullmann. dhaumann added a comment. Ok, I now fully got this, thanks for the explanation. And indeed without any left fill visual feedback is missing. What I wonder is how much of this needs to be configurable. We could also just make the left fill of 4 defau

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. (side note: I am not sure whether to use phabricator.kde.org or invent.kde.org for this. Are they complementary or orthogonal?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: dhaumann, kwrite-devel, kde-framew

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. > No offense meant, but even with the screenshots I still have no idea what this is about :) Good point, I somehow missed to explain the rationale for the change. :) If you are familiar with vim, this would be the `breakindent` and `breakindentopt` settings (th

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

dhaumann added a comment. No offense meant, but even with the screenshots I still have no idea what this is about :) Can you add a before/after screenshot so we can see the visual difference? Also, the "fill left" and "fill right" wording is new, and not intuitively understandable f

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. This is the current dialogue, with two new options at the bottom (the circle had horizontal spring before an unrelated option, I think it was there by accident...?!). F8099358: image.png REPOSITORY R39 KTextEditor REVISI

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos updated this revision to Diff 75533. eudoxos added a comment. Rename config keys as per discussion under D27238 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75440&id=75533 BRANCH dynwrap-marker

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos updated this revision to Diff 75440. eudoxos added a comment. Fix tab/space indentation, fix maximum width. No other glitches known at present. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75361&id=75440 BRANCH dynwrap-marker (bran

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. Note: extra space (right fill) is not computed correctly if tabs are used for line indentation. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. This is an example with right fill of 3 characters, left fill off, with indentation lines (note that they spend all visual lines of the dynamically wrapped line). F8095407: image.png REPOSITORY R39 KTextEditor REVISION D

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos created this revision. eudoxos added a reviewer: VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. eudoxos requested review of this revision. REVISION SUMMARY The configuration UI is somewhat clumsy, some better arrangement sugges