D27292: set the share comment as UDS_COMMENT for the UI to display

2020-02-13 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:dddafae55363: smb: set the share comment as UDS_COMMENT for the UI to display (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27292: set the share comment as UDS_COMMENT for the UI to display

2020-02-10 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug105086 REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27292: set the share comment as UDS_COMMENT for the UI to display

2020-02-10 Thread Harald Sitter
sitter added a comment. We talked about this on telegram and what Kai is thinking of may be the mime comment. Upon review UDS_COMMENT (or KFileItem::comment()) seems to simply not be modeled in dolphin. The model has a Comment column but as far as I can tell the data for that column is

D27292: set the share comment as UDS_COMMENT for the UI to display

2020-02-10 Thread Kai Uwe Broulik
broulik added a comment. The comment will be shown in the status bar when hovering a file. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27292: set the share comment as UDS_COMMENT for the UI to display

2020-02-10 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY currently this seems to not really have any visibility through