D27445: Move tasks from 3px to 2px

niccolove abandoned this revision. niccolove added a comment. I'd actually prefer to make the task manager extend to panel borders. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: ndavis, ngraham, kde-frameworks-devel,

D27445: Move tasks from 3px to 2px

niccolove added a comment. With big panels this is not really a problem, but I feel like a 3px lines takes too much space from the icon space, making it a bit cramped. Here's an example of a theme using a 2px line as well (Sweet KDE, the most downloaded Plasma theme): F8108529: Screenshot_

D27445: Move tasks from 3px to 2px

ndavis added a comment. > This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124 For the record, I use 3px lines in what I have done so far with that task.

D27445: Move tasks from 3px to 2px

ndavis added a comment. I don't think it's really worth it to do this patch for the same reasons as Nate. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27445: Move tasks from 3px to 2px

ngraham added a comment. Technical review: This patch has hardcoded colors in it. Gotta fix that. --- Visual review: F8107681: Screenshot_20200216_154612.png Personally I don't really see the point of it. This patch makes the line so t

D27445: Move tasks from 3px to 2px

niccolove requested review of this revision. niccolove added a comment. Nope, that does not work. Let's stick to 2px. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, micha

D27445: Move tasks from 3px to 2px

niccolove planned changes to this revision. niccolove added a comment. I do prefer the 2px version, but I think a compromise would look best. I will try a 2.5px version, although I'm not sure how good .5 pixel are displayed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL http

D27445: Move tasks from 3px to 2px

niccolove updated this revision to Diff 75798. niccolove added a comment. Used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27445?vs=75797&id=75798 BRANCH 2px_tasks (branched from master) REVISION DETAIL https://phabricator.

D27445: Move tasks from 3px to 2px

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY *gimme a sec* REPOSITORY R242 Plasma Framework (Library) BRANCH 2px_tasks (branched from master) REVISION DET