D27460: fix layout size hints for button labels

ngraham added a comment. This patch also does not fix the media controller buttons' icon sizes, so D27449 is still needed. :/ REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma,

D27460: fix layout size hints for button labels

ngraham added a comment. The System Tray's pin button now looks like this for me: F8112931: Screenshot_20200219_083903.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma,

D27460: fix layout size hints for button labels

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ba0b637de94a: fix layout size hints for button labels (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75976=75977

D27460: fix layout size hints for button labels

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/buttonslayout REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel,

D27460: fix layout size hints for button labels

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Button.qml:62 > I don't understand this part about constraining the width to the parent > height (for all 3) > > If I remove it all the tests still pass. was an extra constraint to have buttons always square, but i added

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75976. mart marked an inline comment as done. mart added a comment. - remove extra check for squareness REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75972=75976 BRANCH phab/buttonslayout

D27460: fix layout size hints for button labels

davidedmundson added inline comments. INLINE COMMENTS > Button.qml:62 > +Layout.minimumHeight: units.iconSizes.tiny > +Layout.maximumWidth: Math.min(parent.height, control.icon.width > > 0 ? control.icon.width : units.iconSizes.small) > +Layout.maximumHeight:

D27460: fix layout size hints for button labels

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in button3.qml:90 > You didn't even run this :( > > 1. icon.name not icon.source > 2. now the comment next to it is wrong > 3. there's a binding loop > > 4. if I make a test without any

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75972. mart marked an inline comment as done. mart added a comment. - fix button display property - add a test for tabbar REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75927=75972 BRANCH

D27460: fix layout size hints for button labels

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in button3.qml:90 > added You didn't even run this :( 1. icon.name not icon.source 2. now the comment next to it is wrong 3. there's a binding loop 4. if I make a test without any text, which is what the thing you're

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75927. mart added a comment. - add an icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75922=75927 BRANCH phab/buttonslayout REVISION DETAIL https://phabricator.kde.org/D27460

D27460: fix layout size hints for button labels

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in button3.qml:90 > this doesn't contain an icon, which is the majority of what this patch is > about added REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27460: fix layout size hints for button labels

davidedmundson added inline comments. INLINE COMMENTS > button3.qml:90 > text: "AA" > -// implicitWidth: minimumWidth FIXME, there is no equivalent? > +implicitWidth: Layout.minimumWidth > } this doesn't contain an icon, which is the

D27460: fix layout size hints for button labels

mart added a comment. latest version, plasmacontrols 2 and 3 one beside the other F8110874: Screenshot_20200218_160904.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma,

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75922. mart added a comment. - some quirks to make it more similar to pc2 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75833=75922 BRANCH phab/buttonslayout REVISION DETAIL

D27460: fix layout size hints for button labels

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Please update tests/components to have it failing before and now passing. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27460: fix layout size hints for button labels

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27460: fix layout size hints for button labels

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY icon sizes and label placements tested correct in several scenarios -