This revision was automatically updated to reflect the committed changes.
Closed by commit R306:c10ca8623903: templates: Convert license statements to
SPDX headers (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D27586?vs=76236&id=76437#toc
REPOSITORY
R306 KParts
cordlandwehr accepted this revision.
cordlandwehr added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kossebau wrote in main.cpp:31
> Hmpf, that slipped me. The regular expression overdoing its job :)
> I guess that will be hit in more KAboutData instances. P
kossebau updated this revision to Diff 76236.
kossebau marked an inline comment as done.
kossebau added a comment.
remove unwanted change in KAboutData copyright string
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27586?vs=76194&id=76236
BRANCH
spdxlice
kossebau marked an inline comment as done.
kossebau added inline comments.
INLINE COMMENTS
> cordlandwehr wrote in main.cpp:31
> I do not think that we should change this
Hmpf, that slipped me. The regular expression overdoing its job :)
I guess that will be hit in more KAboutData instances. Per
cordlandwehr requested changes to this revision.
cordlandwehr added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.cpp:31
> KAboutLicense::GPL,
> -i18n("Copyright %{CURRENT_YEAR} %{AUTHOR}"));
> +i18n("SPDX-FileCopyrightText: %{CURR
kossebau created this revision.
kossebau added reviewers: cordlandwehr, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REPOSITORY
R306 KParts
BRANCH
spdxlicensefortemplate
REVISION DETAIL
https://phab