D27589: Try to apply the colorscheme of the current theme to QIcons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b7fa6e0e916b: Try to apply the colorscheme of the current theme to QIcons (authored by davidre). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27589: Try to apply the colorscheme of the current theme to QIcons

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack, ngraham, mart Cc: mart, wbauer, cblack,

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre updated this revision to Diff 76284. davidre added a comment. - Introduce Plasma::Theme::palette REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27589?vs=76197=76284 BRANCH qiconcolor (branched from master) REVISION DETAIL

D27589: Try to apply the colorscheme of the current theme to QIcons

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iconitem.cpp:600 > } else if (!m_icon.isNull()) { > + >

D27589: Try to apply the colorscheme of the current theme to QIcons

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack, ngraham Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D27589: Try to apply the colorscheme of the current theme to QIcons

wbauer added a comment. Confirmed. I tried out the patch now, and that problem is gone. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack,

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre added a comment. In D27589#616106 , @wbauer wrote: > Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ? Yes seems like the exact bug REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched

D27589: Try to apply the colorscheme of the current theme to QIcons

wbauer added a comment. Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ? REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack,

D27589: Try to apply the colorscheme of the current theme to QIcons

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Patch works as advertised and the code LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre edited the test plan for this revision. davidre added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Before icons loaded internally with QIcon::fromTheme were being colored with the colors from the current global