dfaure added a comment.
Nobody cares about broken CI, or my comment here wasn't noticed, so I fixed
it myself. https://phabricator.kde.org/D28188
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D27614
To: bshah, ngraham, lbeltrame, sitter
Cc: dfaure, sitter,
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:17
> +add_custom_target(breeze-generate-24px-versions-dark ALL
> +COMMAND ${BASH_EXE} ${CMAKE_SOURCE_DIR}/generate-24px-versions.sh
> ${CMAKE_CURRENT_BINARY_DIR}/generated/
> WORKING_DIRECTORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix
is not user-writable (authored by bshah).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
bshah updated this revision to Diff 76278.
bshah added a comment.
rebase
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27614?vs=76256=76278
BRANCH
bshah/fix-build
REVISION DETAIL
https://phabricator.kde.org/D27614
AFFECTED FILES
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
I'd rather have the excess spaces been done away with. Otherwise LGTM, please
rebase and land.
REPOSITORY
R266 Breeze Icons
BRANCH
bshah/fix-build
REVISION DETAIL
lbeltrame added a comment.
+1
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D27614
To: bshah, ngraham, lbeltrame
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
bshah created this revision.
bshah added reviewers: ngraham, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bshah requested review of this revision.
REVISION SUMMARY
- Validate only the files and symlinks
- Fix target names, they were swapped
