D27807: Changed style of pressed list item to be consistent

2020-03-04 Thread Niccolò Venerandi
niccolove abandoned this revision. niccolove added a comment. Actually, there is a proper way to do this. Gimme a sec. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, ndavis, kde-framewo

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Nathaniel Graham
ngraham added a comment. In D27807#621347 , @ndavis wrote: > It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. Because then people who are both subscribed to the mailing list and a

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a subscriber: plasma-devel. ndavis added a comment. It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg,

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a comment. Wouldn't it make more sense to use different pressed and hovered states instead of designing the pressed state to be used as a hover state because the hover state isn't used? Also, it's strange that listitem.svg and viewitem.svg both exist and are both used for simila

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY The style of pressed- listitem (which is actually often used for hover as well, while the hover- listitem is never