D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Hmm, right, didn't think about that :( Guess if we want to have this, we need to improve the read/writeConfig functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc:

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. In D27844#671380 , @dhaumann wrote: > I suggest to revert, and send a notification with the change to kde-distro-packa...@kde.org to avoid that many users break their configuration. Okay, doing now. REPOSITORY

D27844: Store and fetch complete view config in and from session config

dhaumann added a comment. I suggest to revert, and send a notification with the change to kde-distro-packa...@kde.org to avoid that many users break their configuration. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar,

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. Seems this change has some sideeffects I did not experience when I played with this, but which are now uncovering as it hits people usinjg KF 5.70 : config seems to write any settings, also the ones inherited from global defaults, as view-specific settings, and

D27844: Store and fetch complete view config in and from session config

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0611924df7b0: Store and fetch complete view config in and from session config (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Yes, please push, thanks! REPOSITORY R39 KTextEditor BRANCH fullviewconfigsessionsupport REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. When it comes to Zoom, I would only expect it adapts to Global zoom settings again only once if I have reset my manual zooming to Default again. Though. seems Zoom is not covered by that config setting object... please not the "not" in "are not yet covered" in

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Zoom is like all view stuff local, yes, I assume that is often not wanted. But that is a orthogonal issue. The same could be said for "dynamic word wrap", very seldom you want to set that for one view. On the other side, for the global config, one has the

D27844: Store and fetch complete view config in and from session config

dhaumann added a comment. I guess we can give this a try. As I understand, though, with this patch you will never be able to use e.g. a global zoom once you change the zoom of a view. This was different before this patch. Which brings me to another point: e.g. zoom should simply zoom

D27844: Store and fetch complete view config in and from session config

cullmann accepted this revision as: cullmann. cullmann added a comment. This revision is now accepted and ready to land. Hmm, actually not sure why we didn't do that before. I think this change makes sense. Perhaps Dominik has some idea why we didn't do that in the past? I myself think

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. I am a bit surprised this was not already done before? Did I miss something? Settings like color scheme & zoom are not yet covered, but they might want to be restored as well fpr completeness, or? If someone changed them from the general settings, they might

D27844: Store and fetch complete view config in and from session config

kossebau created this revision. kossebau added reviewers: Kate, loh.tar, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY The manual "Dynamic Word Wrap" config