dfaure closed this revision.
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D27876
To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
dfaure added a comment.
It did indeed... Thanks, fixing.
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27876
To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
kossebau added inline comments.
INLINE COMMENTS
> rearrangecolumns.cpp:37
> +QTimer::singleShot(500, , [&]() {
> +pm.setSourceColumns(QVector() << 2 << 1 << 0 << 3);
> +});
Thanks :) This one slipped?
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
dfaure updated this revision to Diff 77047.
dfaure added a comment.
Use initializer lists
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27876?vs=77044=77047
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27876
AFFECTED FILES
kossebau added a comment.
Small nitpick: can we have initializer lists for the stringlist and columns
in the tests, to promote (IMHO) good C++ code? :)
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27876
To: dfaure, kossebau, vkrause,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27876
To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,
dfaure created this revision.
dfaure added reviewers: kossebau, vkrause, davidedmundson, ahiemstra.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
Otherwise the view won't update, when doing this
