This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R306:b617fc005751: KParts: add PartLoader as replacement to
KMimeTypeTrader for parts (authored by dfaure).
REPOSITORY
R3
dfaure added a comment.
Yeah I guess "looks reasonable" is the most I can expect :-)
Any chance you could take a look at https://phabricator.kde.org/D27967 which
is needed for this to land? Thanks.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D27966
To: dfaure
aacid added a comment.
Looks reasonable to me, but i'm not a huge expert here either, i guess you
can commit given you are the expert.
Or maybe wait a few days in case someone else has commits?
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D27966
To: dfaure, aa
dfaure updated this revision to Diff 77474.
dfaure added a comment.
Document how to load a part from a given KPluginMetaData
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27966?vs=77381&id=77474
REVISION DETAIL
https://phabricator.kde.org/D27966
AFFECTE
aacid added inline comments.
INLINE COMMENTS
> dfaure wrote in partloader.h:59
> This is an excellent point, thanks for this feedback.
>
> Loading a part from a given KPluginMetadata is extremely simple, though:
>
> KPluginLoader loader(md.fileName());
> m_part = loader.factory()->create(th
dfaure updated this revision to Diff 77381.
dfaure added a comment.
Ensure no duplicates in partsForMimeType
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27966?vs=77340&id=77381
REVISION DETAIL
https://phabricator.kde.org/D27966
AFFECTED FILES
src/CM
dfaure added inline comments.
INLINE COMMENTS
> aacid wrote in partloader.h:59
> What's the use for this? The function below doesn't let me chose which one i
> want (i guess it always uses the one with the most preference?), so why would
> i need to query which parts are available?
>
> Maybe t
aacid added inline comments.
INLINE COMMENTS
> partloader.h:59
> + */
> +KPARTS_EXPORT QVector partsForMimeType(const QString
> &mimeType);
> +
What's the use for this? The function below doesn't let me chose which one i
want (i guess it always uses the one with the most preference?),
dfaure created this revision.
dfaure added reviewers: aacid, nicolasfella, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
It's based on the JSON metadata embedded into the plugins in kf5/pa
