cullmann added a comment.
Better, but VHDL hl is still very slow, need to take a deeper look into it :/
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D28015
To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch,
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e6090be50f0d: extend indexer to detect dynamic=true
regexes that have no place holders to… (authored by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
cullmann added a comment.
Yes, I will fix the issues and then commit this as one thingy.
Thanks for taking a look :=)
My colleague was very unhappy with the VHDL performance :P
The highlighting shouldn't take as long as a hardware simulator.
REPOSITORY
R216 Syntax Highlighting
BRANCH
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I guess in a followup commit the reported issues will be fixed? :-)
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28015
To:
cullmann updated this revision to Diff 77526.
cullmann added a comment.
remove useless output of stray azOffset var
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28015?vs=77525=77526
BRANCH
master
REVISION DETAIL
cullmann added reviewers: nibags, dhaumann, vkrause.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D28015
To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2,
domson, michaelh, ngraham, bruns,
cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
see bug 418778
VHDL highlighting is very slow as close to all regexes are marked as dynamic
