broulik closed this revision.
broulik added a comment.
https://phabricator.kde.org/R305:4caaf107f1d4f45ff28d0de1b7e7e541e5827e3a
REPOSITORY
R305 KNotifyConfig
REVISION DETAIL
https://phabricator.kde.org/D28121
To: broulik, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack,
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
Your `if(` style is now inconsistent with the `endif(`.
Code LGTM
REPOSITORY
R305 KNotifyConfig
REVISION DETAIL
https://phabricator.kde.org/D28121
To: broulik, #frameworks, sitter
broulik created this revision.
broulik added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
So it matches what `KNotification` is doing, especially since Phonon
