ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kfontchooserdialog.cpp:97
> The theoretical answer is yes, this would crash. But note that the user
> cannot just close the application by clicking somewhere while a modal dialog
> is up. This requires much more subtle interact
dfaure added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in kfontchooserdialog.cpp:97
> hmmm. dfaure knows more about exec() and event loops more than me.
> @dfaure WDYT?
The theoretical answer is yes, this would crash. But note that the user cannot
just close the application by cl
ahmadsamir added inline comments.
INLINE COMMENTS
> meven wrote in kfontchooserdialog.cpp:93
> Shouldn't this be not commented
IIUC, if a function is declared static inside the class body (e.g. in the
header file), the static keyword can't be repeated when it's defined outside
the class body.
meven added inline comments.
INLINE COMMENTS
> kfontchooserdialog.cpp:93
> +
> +// static
> +int KFontChooserDialog::getFontDiff(QFont &theFont,
> KFontChooser::FontDiffFlags &diffFlags,
Shouldn't this be not commented
> kfontchooserdialog.cpp:110
> +
> +// static
> +int KFontChooserDialog::ge
kossebau added inline comments.
INLINE COMMENTS
> kfontchooserdialog.cpp:97
> +{
> +KFontChooserDialog dlg(flags | KFontChooser::ShowDifferences, parent);
> +dlg.setObjectName(QStringLiteral("Font Selector"));
Is having dialog objects on the stack a good idea?
What if the application ge
This revision was automatically updated to reflect the committed changes.
ahmadsamir marked 2 inline comments as done.
Closed by commit R236:2e9cace39272: Copy KFontDialog from KDELibs4Support to
KWidgetAddons, now KFontChooserDialog (authored by ahmadsamir).
REPOSITORY
R236 KWidgetsAddons
CHA
dfaure accepted this revision.
REPOSITORY
R236 KWidgetsAddons
BRANCH
l-kfontdlg (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28122
To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven,
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack,
ahmadsamir marked 3 inline comments as done.
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kfontchooserdialog.h:81
> Do @param need to be in order of the arguments? (I'm not sure)
They should be, it's more logical.
> dfaure wrote in kfontchooserdialog.h:89
> Good call. I c
ahmadsamir updated this revision to Diff 78251.
ahmadsamir added a comment.
@param should have the same order as the in the ctor declaration (patterns
make life slightly easier)
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28122?vs=78249&id=78251
dfaure accepted this revision.
dfaure added inline comments.
INLINE COMMENTS
> kfontchooserdialog.h:81
> + *
> + * @param parent The parent widget of the dialog, if any.
> + * @param flags Defines how the font chooser is displayed.
Do @param need to be in order of the arguments? (I'm
ahmadsamir updated this revision to Diff 78249.
ahmadsamir marked an inline comment as done.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Update the screenshot in the docs, Breeze style/colors
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://
ahmadsamir marked 6 inline comments as done.
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kfontchooserdialog.h:89
> The usual way in Qt API is that the parent is the last argument, rather than
> the first.
>
> But for this to be convenient, the fontlist argument would hav
ahmadsamir updated this revision to Diff 78241.
ahmadsamir retitled this revision from "Move/port KFontDialog from
KDELibs4Support to KWidgetAddons" to "Copy KFontDialog from KDELibs4Support to
KWidgetAddons, now KFontChooserDialog".
ahmadsamir edited the summary of this revision.
ahmadsamir edit
13 matches
Mail list logo
