D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfontchooserdialog.cpp:38 > + > +void stripRegularStyleName(QFont ); > +}; Should be static. Even file-static (move the implementation further up in the

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78153. ahmadsamir added a comment. Tweak docs REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=78124=78153 BRANCH l-kfontdlg (branched from master) REVISION DETAIL

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir added a comment. In D28122#631254 , @kossebau wrote: > Please also add a note in the documentation when to use new-name-of-KFontDialog and when QFontDialog, i.e. in which use-cases new-name-of-KFontDialog is superior and not

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78124. ahmadsamir added a comment. - Rename to KFontChooserDialog to prevent conflict with the one from KDELibs4Support - Document "features" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

kossebau added a comment. Please also add a note in the documentation when to use KFontDialog and when QFontDialog, i.e. in which use-cases KFontDialog is superior and not using the non-platform one is justified. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontdlg (branched from master)

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir added a comment. In D28122#631237 , @kossebau wrote: > Moving a class (and thus its exported symbols) from a library to another one in its public dependency interface should be doable I guess (no actual experience in having done that

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

kossebau added a comment. Moving a class (and thus its exported symbols) from a library to another one in its public dependency interface should be doable I guess (no actual experience in having done that though). But you sadly cannot change/remove exported symbols and the data layout,

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Please wait for me review. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontdlg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28122 To:

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 77904. ahmadsamir added a task: T12760: Port/move KFontDialog from KDELibs4Support to KWidgetAddons. ahmadsamir added a comment. Link to KF6 task REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Drop relative size bits, seems not that used - Use a