D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

dfaure added a comment. QMimeDatabase was modeled after QFontDatabase, so it's not surprising that they both work the same way ;) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28193#633829 , @dfaure wrote: > I don't think this makes any difference, they all share the same underlying private singleton. > So all this does is to use a tiny bit more mem

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

dfaure added a comment. I don't think this makes any difference, they all share the same underlying private singleton. So all this does is to use a tiny bit more memory while the widget is up (the member var). The additional CPU usage without this patch or the additional memory usage wit

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir updated this revision to Diff 78383. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Verbatim REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28193?vs=78266&id=78383 BRANCH l-kfontchooser-2 (branched from m

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir reclaimed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir updated this revision to Diff 78266. ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28193?vs=78192&id=78266 BRANCH l-kfontchooser-2 (branched from master) REVISION

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in KFontChooser::Private m