D28223: Add "Stat" prefix to StatDetails Enum entries

meven added a comment. In D28223#633824 , @meven wrote: > Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/ > I like it a lot more, this adds quite a lot

D28223: Add "Stat" prefix to StatDetails Enum entries

This revision was automatically updated to reflect the committed changes. Closed by commit R241:36038b904f68: Add Stat prefix to StatDetails Enum entries (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78401=78429 REVISION DETAIL

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked an inline comment as done. meven added a comment. Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/ I like it a lot more, this adds quite a lot of type safety. REPOSITORY R241 KIO BRANCH

D28223: Add "Stat" prefix to StatDetails Enum entries

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28223 To: meven, #frameworks, kossebau, dfaure Cc: davidre, broulik, kde-frameworks-devel,

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in statjob.cpp:106 > This is a weird way of doing this. > > A C-style enum is used like KIO::StatBasic. > Here you're using the C++11-class-enum syntax on a C-style enum, which I'm > not sure

D28223: Add "Stat" prefix to StatDetails Enum entries

meven updated this revision to Diff 78401. meven added a comment. Properly use KIO::Stat* as C-style enum REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78301=78401 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28223 AFFECTED FILES

D28223: Add "Stat" prefix to StatDetails Enum entries

dfaure added inline comments. INLINE COMMENTS > statjob.cpp:106 > { > -KIO::StatDetails detailsFlag = KIO::StatDetail::Basic; > +KIO::StatDetails detailsFlag = KIO::StatDetail::StatBasic; > if (details > 0) { This is a weird way of doing this. A C-style enum is used like

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28223 To: meven, #frameworks, kossebau, dfaure Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > davidre wrote in global.h:322 > I think this enum was not released yet Indeed it will be part of KF 5.69 (as the comment above the enum tells), view discussion in D25010

D28223: Add "Stat" prefix to StatDetails Enum entries

davidre added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest I think this enum was not released yet REPOSITORY R241 KIO

D28223: Add "Stat" prefix to StatDetails Enum entries

broulik added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest Is this change source-compatible? REPOSITORY R241 KIO REVISION

D28223: Add "Stat" prefix to StatDetails Enum entries

meven created this revision. meven added reviewers: Frameworks, kossebau, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Relates to D25010 TEST PLAN