D28476: Samba: Ensure to differenciate mounts sharing the same source

meven added a comment. In D28476#639524 , @bruns wrote: > The comment and commit message are lacking required information. One should not have to go to the bug report to actually see why this is needed. How about the commit title "Ensure

D28476: Samba: Ensure to differenciate mounts sharing the same source

bruns added a comment. The comment and commit message are lacking required information. One should not have to go to the bug report to actually see why this is needed. While the summary has the BR reference, the code comment is totally unclear. REPOSITORY R245 Solid REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

This revision was automatically updated to reflect the committed changes. Closed by commit R245:a99c6136da2d: Samba: Ensure to differenciate mounts sharing the same source (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79035=79036

D28476: Samba: Ensure to differenciate mounts sharing the same source

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. You know, I may have noticed this when working on kinfocenter and then quickly forgotten about it again  Good stuff! REPOSITORY R245 Solid BRANCH master REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79035. meven added a comment. Correct typo in comment REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79032=79035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28476 AFFECTED FILES

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79032. meven marked an inline comment as done. meven added a comment. Use QLatin1Char REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79030=79032 BRANCH master REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

ahmadsamir added inline comments. INLINE COMMENTS > fstabhandling.cpp:131 > +return source + ':' + mountpoint; > } > return source; Nitpick: QLatin1Char. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28476 To: meven, #frameworks Cc: ahmadsamir,

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79030. meven marked an inline comment as done. meven added a comment. Use QLatin1String REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79025=79030 BRANCH master REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

anthonyfieroni added inline comments. INLINE COMMENTS > fstabhandling.cpp:127 > return fstype + mountpoint; > +} else if (fstype == "cifs") { > +// append mountpoints to samba device name as they don't contain it > in getmntent use `QLatin1String` REPOSITORY R245

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79025. meven added a comment. Use a char instead of char* REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79023=79025 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28476 AFFECTED FILES

D28476: Samba: Ensure to differenciate mounts sharing the same source

ahmadsamir added a subscriber: sitter. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28476 To: meven, #frameworks Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79023. meven added a comment. Fix comment REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79022=79023 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28476 AFFECTED FILES

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY `getmntent` for samba returns fsname of the form "//server/folder" (same as `mount`)