This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f4e0183adfd8: Fix lifetime of slot in KIO-MTP (authored
by feverfew).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28520?vs=79196=79609
REVISION DETAIL
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
Please push to 20.04, there is still time.
REPOSITORY
R320 KIO Extras
BRANCH
slotLifetime (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28520
To: feverfew, akrutzler, dfaure,
meven accepted this revision.
REPOSITORY
R320 KIO Extras
BRANCH
slotLifetime (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28520
To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov,
apol accepted this revision.
REPOSITORY
R320 KIO Extras
BRANCH
slotLifetime (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28520
To: feverfew, akrutzler, dfaure, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov,
iasensio,
feverfew added a comment.
@apol just found another one where this occurs, forgot about it but noticed
it earlier as well. This doesn't affect KIOFuse as much though (as we don't
listen to the processedSize() signal).
I'll wait for another approval, or before 20.04 tagging, whichever
feverfew updated this revision to Diff 79196.
feverfew added a comment.
- Fix another slot lifetime
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28520?vs=79154=79196
BRANCH
slotLifetime (branched from master)
REVISION DETAIL
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Makes sense
REPOSITORY
R320 KIO Extras
BRANCH
slotLifetime (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28520
To: feverfew, akrutzler, dfaure, elvisangelaccio,
feverfew created this revision.
feverfew added reviewers: akrutzler, dfaure, elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
feverfew requested review of this revision.
REVISION SUMMARY
This slot was incorrectly made to