D28673: [PackageUrlInterceptor] Make QRegularExpression static

ahmadsamir commandeered this revision. ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. Should be handled by https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/2 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28673: [PackageUrlInterceptor] Make QRegularExpression static

ahmadsamir abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: ahmadsamir, #plasma, broulik Cc: ahmadsamir, bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28673: [PackageUrlInterceptor] Make QRegularExpression static

pino added a comment. In D28673#672845 , @broulik wrote: > so, can the regexp be replaced or does it need to stay? Sure: look for `/ui/` in path, and if it is there, join what's before it + prefix + what's after it. REPOSITORY R242

D28673: [PackageUrlInterceptor] Make QRegularExpression static

broulik added a comment. so, can the regexp be replaced or does it need to stay? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28673: [PackageUrlInterceptor] Make QRegularExpression static

bruns added a comment. In D28673#644778 , @broulik wrote: > Yeah, can probably be a `startsWith` unlikely for `QUrl::toString()` ... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To:

D28673: [PackageUrlInterceptor] Make QRegularExpression static

broulik planned changes to this revision. broulik added a comment. Yeah, can probably be a `startsWith` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28673: [PackageUrlInterceptor] Make QRegularExpression static

pino added a comment. Does it really need to be a regular expression, though? A simple string search & replace should do the same thing. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: pino, kde-frameworks-devel,

D28673: [PackageUrlInterceptor] Make QRegularExpression static

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids recompiling it every time. TEST PLAN Called 27 times on plasmashell startup