D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. And it seems recentdocuments:/ shows representation of recent "documents", parsed from .desktop files in ~/.local/share/RecentDocuments/, so it doesn't need to be handled here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To:

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. I did some more testing: $ grep -ir :local *protocol about.protocol:Class=:local activities.protocol:Class=:local applications.protocol:Class=:local ar.protocol:Class=:local baloosearch.protocol:Class=:local

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. OK, thanks for the pointers. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Hm. So, this is a bit complicated I've noticed. Let's consider the following cases: - `desktop:` is not a local file but can set and read dir icons without penalty - `camera:` is not a local file AND `Class=:local` BUT (I think?) cannot set dir icons as it

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir updated this revision to Diff 79643. ahmadsamir added a comment. --verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28679?vs=79640=79643 BRANCH l-kprop (branched from master) REVISION DETAIL https://phabricator.kde.org/D28679 AFFECTED

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. I thought about that, but since I am not experienced with network mounts (I rarely use them), I didn't expand the test In D28679#644274 , @sitter wrote: > Looks reasonable. Though... Shouldn't that rather be any

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

broulik added a comment. > assuming we have a way of telling which slaves are remote `KProtocolInfo::protocolClass(url.scheme())` not being `":local"` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik,

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Looks reasonable. Though... Shouldn't that rather be any protocol that isn't `file`? Or at least all that are remote? (assuming we have a way of telling which slaves are remote) If I open sftp it also shows no dir icons yet lets me set one. REPOSITORY R241 KIO

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. I don't have access to a samba share so I tested with an sftp:// one, after modifying the diff locally. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n,

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Changing the icon of a dir on a samba share doesn't seem to have an effect, this is intentional as