D28755: Breeze Icons cannot be built from read-only source location

2020-04-16 Thread Pino Toscano
pino added a comment. Fixed with def21bf6c691a40bef233efd898fcb7ff57d55bb , thanks for the notice. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28755 To: marten, #breeze, ngraham

D28755: Breeze Icons cannot be built from read-only source location

2020-04-16 Thread Ben Cooksley
bcooksley added a comment. This does not build on the CI system - please see https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20SUSEQt5.12/lastFailedBuild/ amongst others. REPOSITORY R266 Breeze Icons REVISION DETAIL

D28755: Breeze Icons cannot be built from read-only source location

2020-04-15 Thread Jonathan Marten
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0a5dd2972b62: Allow building from a read-only source location (authored by marten). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28755?vs=79867=80219

D28755: Breeze Icons cannot be built from read-only source location

2020-04-12 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice improvement. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28755 To: marten, #breeze, ngraham Cc: ngraham, pino, kde-frameworks-devel, LeGast00n,

D28755: Breeze Icons cannot be built from read-only source location

2020-04-11 Thread Jonathan Marten
marten updated this revision to Diff 79867. marten added a comment. Yes, that would mean fewer changes to the validate_svg.sh script. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28755?vs=79845=79867 REVISION DETAIL

D28755: Breeze Icons cannot be built from read-only source location

2020-04-11 Thread Pino Toscano
pino added a comment. Or maybe the other way round: - add an optional parameter to the script to specify the source directory, defaulting to "." - run the script in the build directory, passing the source directory as parameter REPOSITORY R266 Breeze Icons REVISION DETAIL

D28755: Breeze Icons cannot be built from read-only source location

2020-04-11 Thread Jonathan Marten
marten created this revision. marten added a reviewer: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY In the situation, for example, where a master source tree may be shared among a number