D28855: put minimumkeepsize actually in the netpref KCM

sitter abandoned this revision. sitter added a comment. moved to https://invent.kde.org/frameworks/kio/-/merge_requests/123 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D28855: put minimumkeepsize actually in the netpref KCM

ahmadsamir added inline comments. INLINE COMMENTS > netpref.cpp:87 > +connect(cb_globalMarkPartial, ::toggled, > +partialWidget, [partialWidget](bool checked) { > partialWidget->setEnabled(checked); }); > +globalLayout->addWidget(partialWidget); Why not "::setEnabled"

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. And didn't we have a better spinny box for byte units somewhere? Where the user can put `1 byte` or `1 kib` or `1 gib` and the box knows what to do? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc:

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. F8240046: Screenshot_20200415_164836.png I'm very open for better labels, it's a horrible concept to explain in a few words. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham,

D28855: put minimumkeepsize actually in the netpref KCM

sitter updated this revision to Diff 80204. sitter added a comment. improve label a tad REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28855?vs=80203=80204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28855 AFFECTED FILES

D28855: put minimumkeepsize actually in the netpref KCM

sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I didn't even know it was a thing! by the looks of it the setting only applies