meven added inline comments.
INLINE COMMENTS
> dfaure wrote in kio_smb.h:96
> Excellent idea, but why wait for KF6?
>
> We could implement a subclass of SlaveBase, in KIO, let's call it
> SlaveBaseV2, which
>
> - Reimplements all the virtual methods from SlaveBase, in a private section
> -
dfaure added inline comments.
INLINE COMMENTS
> sitter wrote in kio_smb.h:96
> Sure, if you think it's solid enough from an API POV.
>
> I was thinking that we should amend the slavebase API for KF6 in general.
> Instead of having error/finished/opened all functions on an API level should
>
sitter added inline comments.
INLINE COMMENTS
> dfaure wrote in kio_smb.h:96
> Whenever we port a 3rd slave to it ;-)
Sure, if you think it's solid enough from an API POV.
I was thinking that we should amend the slavebase API for KF6 in general.
Instead of having error/finished/opened all
dfaure added inline comments.
INLINE COMMENTS
> meven wrote in kio_smb.h:96
> KF6 ?
> Or once we want to use it in KIO ?
Whenever we port a 3rd slave to it ;-)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28909
To: sitter, dfaure
Cc: meven,
meven added inline comments.
INLINE COMMENTS
> dfaure wrote in kio_smb.h:96
> The class is simple enough, but I'm wondering if at some point we might want
> to provide it in KIO [as is, not with a d pointer].
KF6 ?
Or once we want to use it in KIO ?
REPOSITORY
R320 KIO Extras
REVISION
meven added inline comments.
INLINE COMMENTS
> kio_smb_browse.cpp:184
> } else {
> -error(passwordError, url.toString());
> }
Empty else clause leftover
> kio_smb_file.cpp:169
> if (errNum == EACCES)
> -
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kio_smb.cpp:162
> +{
> +#warning this was finishing before but in sftp and fish we do not finish so
> I guess not finishing is the way to go
> +
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
the Result system was originally introduced to the FTP slave and now
