This revision was automatically updated to reflect the committed changes.
Closed by commit R127:185f40195dc0: [Wayland] Add to PlasmaWindowManagement
protocol windows stacking order (authored by bport).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
bport added a dependent revision: D29231: [WIP] Add keyboard_shortcuts_inhibit
protocol.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
To: bport, zzag, davidedmundson
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
zzag added inline comments.
INLINE COMMENTS
> plasma-window-management.xml:74
>
> +
> +
To be in-line with upstream standards, please add ``.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
To: bport, zzag, davidedmundson
Cc: meven,
meven added inline comments.
INLINE COMMENTS
> plasmawindowmanagement_interface.h:76
>
> +
> +/**
A space too many
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
To: bport, zzag, davidedmundson
Cc: meven, kde-frameworks-devel, LeGast00n, cblack,
zzag added inline comments.
INLINE COMMENTS
> plasmawindowmanagement_interface.cpp:297
>
> +void PlasmaWindowManagementInterface::setStackingOrder(const
> QVector& stackingOrder)
> +{
coding style: whitespace before `&`
REPOSITORY
R127 KWayland
REVISION DETAIL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
bport updated this revision to Diff 80901.
bport added a comment.
Add missing const ref and fix coding style
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29054?vs=80887=80901
REVISION DETAIL
https://phabricator.kde.org/D29054
AFFECTED FILES
zzag added inline comments.
INLINE COMMENTS
> plasmawindowmanagement.cpp:47
> void windowCreated(org_kde_plasma_window *id, quint32 internalId);
> +void setStackingOrder(const QVector& ids);
>
Coding style: whitespace before `&` and `*`
> plasmawindowmanagement_interface.cpp:297
>
bport updated this revision to Diff 80887.
bport added a comment.
Increase protocol version and use const ref for QVector parameter
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29054?vs=80784=80887
REVISION DETAIL
https://phabricator.kde.org/D29054
zzag added inline comments.
INLINE COMMENTS
> plasmawindowmanagement.cpp:242
>
> +void PlasmaWindowManagement::Private::stackingOrderCallback(void *data,
> org_kde_plasma_window_management *interface, wl_array *ids) {
> +auto wm = reinterpret_cast(data);
The opening brace must be on a
bport updated this revision to Diff 80784.
bport marked 4 inline comments as done.
bport added a comment.
- Send stack order on bind
- Check ressource have good protocol version
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29054?vs=80772=80784
davidedmundson added inline comments.
INLINE COMMENTS
> plasma-window-management.xml:77
> +
> +This event will be sent when stacking order changed
> +
we also need to send it on bind
> plasma-window-management.xml:83
>
>
>
Can we change them all at once.
>
bport added a dependent revision: D29056: [libtaskmanager] add stacking order
data for wayland.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
bport created this revision.
bport added reviewers: zzag, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
AFFECTED FILES
14 matches
Mail list logo
