This revision was automatically updated to reflect the committed changes.
Closed by commit R282:f0b1c412074a: [NetworkManager-qt] Replace foreach with
range/index for loop (authored by ahmadsamir).
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
jgrulich accepted this revision.
REPOSITORY
R282 NetworkManagerQt
BRANCH
l-foreach-2 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29086
To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
ahmadsamir updated this revision to Diff 80860.
ahmadsamir added a comment.
Some missing ones
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29086?vs=80858=80860
BRANCH
l-foreach-2 (branched from master)
REVISION DETAIL
jgrulich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R282 NetworkManagerQt
BRANCH
l-foreach-2 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29086
To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n,
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.
TEST PLAN
make && ctest
REPOSITORY
R282 NetworkManagerQt
BRANCH
l-foreach-2